search

canonical / xdg_desktop_portal.dart

Mozilla Public License 2.0
11 stars 5 forks source link

Add Account portal #49

Closed aospiridonov closed 2 years ago

aospiridonov commented 2 years ago

Add Account portal

robert-ancell commented 2 years ago

Thanks for this! Can you rebase so this is a single commit? Also please add Fixes https://github.com/canonical/xdg_desktop_portal.dart/issues/1 to the commit message.

aospiridonov commented 2 years ago

Thanks for this! Can you rebase so this is a single commit? Also please add Fixes https://github.com/canonical/xdg_desktop_portal.dart/issues/1 to the commit message.

Please help me! How to rebase so this is a single commit?

From the command line: git rebase main or git rebase -i main to merge together any patches.

aospiridonov commented 2 years ago

fix comments PR

aospiridonov commented 2 years ago

Thanks for this! Can you rebase so this is a single commit? Also please add Fixes https://github.com/canonical/xdg_desktop_portal.dart/issues/1 to the commit message.

Please help me! How to rebase so this is a single commit?

From the command line: git rebase main or git rebase -i main to merge together any patches.

after git rebase main write "HEAD detached at de3405e" What do I need to do next?

robert-ancell commented 2 years ago

Thanks for this! Can you rebase so this is a single commit? Also please add Fixes https://github.com/canonical/xdg_desktop_portal.dart/issues/1 to the commit message.

Please help me! How to rebase so this is a single commit? From the command line: git rebase main or git rebase -i main to merge together any patches.

after git rebase main write "HEAD detached at de3405e" What do I need to do next?

Once you have all the changes as you expect, then use git add to accept those changes and then git rebase --continue to finish the rebase.

aospiridonov commented 2 years ago

Thanks for this! Can you rebase so this is a single commit? Also please add Fixes https://github.com/canonical/xdg_desktop_portal.dart/issues/1 to the commit message.

Please help me! How to rebase so this is a single commit? From the command line: git rebase main or git rebase -i main to merge together any patches.

after git rebase main write "HEAD detached at de3405e" What do I need to do next?

Once you have all the changes as you expect, then use git add to accept those changes and then git rebase --continue to finish the rebase.

I can't do it. Could you help me? I can add you as a collaborators to my repository.

robert-ancell commented 2 years ago

I can't do it. Could you help me? I can add you as a collaborators to my repository.

All done, should be good to land now :)

codecov-commenter commented 2 years ago

Codecov Report

Merging #49 (dd5d466) into main (a7c143f) will decrease coverage by 0.37%. The diff coverage is 85.71%.

:exclamation: Current head dd5d466 differs from pull request most recent head 1774cd8. Consider uploading reports for the commit 1774cd8 to get more accurate results

@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
- Coverage   92.27%   91.90%   -0.38%     
==========================================
  Files           2        2              
  Lines         466      494      +28     
==========================================
+ Hits          430      454      +24     
- Misses         36       40       +4
Impacted Files Coverage Δ
lib/src/xdg_desktop_portal_client.dart 92.99% <85.71%> (-0.47%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

aospiridonov commented 2 years ago

I can't do it. Could you help me? I can add you as a collaborators to my repository.

All done, should be good to land now :)

You are wonderful! Thank you very much)