search

canonical / xdg_desktop_portal.dart

Mozilla Public License 2.0
12 stars 6 forks source link

Add Camera portal #59

Closed aospiridonov closed 2 years ago

aospiridonov commented 2 years ago

Add Camera portal.

codecov-commenter commented 2 years ago

Codecov Report

Merging #59 (7febe8a) into main (5e1788d) will increase coverage by 0.12%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   96.07%   96.20%   +0.12%     
==========================================
  Files          13       14       +1     
  Lines         510      527      +17     
==========================================
+ Hits          490      507      +17     
  Misses         20       20
Impacted Files Coverage Δ
lib/src/xdg_camera_portal.dart 100.00% <100.00%> (ø)
lib/src/xdg_desktop_portal_client.dart 91.30% <100.00%> (+0.39%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

aospiridonov commented 2 years ago

I'm not sure how useful this is without pipewire support in Dart but no harm in implementing.

Yes, dart is not support pipewire. Can you suggest what needs to be done for this? Or make a repository and try to make it together too. If it's relevant of course.

It would be nice to also implement the IsCameraPresent property as well, though that could be in a separate PR.

I was thinking about property IsCameraPresent. Can make some kind of common interface? Since there are properties in other portals.

robert-ancell commented 2 years ago

I'm not sure how useful this is without pipewire support in Dart but no harm in implementing.

Yes, dart is not support pipewire. Can you suggest what needs to be done for this? Or make a repository and try to make it together too. If it's relevant of course.

I haven't investigated what we can do with Dart and Pipewire yet, but you're welcome to try!

It would be nice to also implement the IsCameraPresent property as well, though that could be in a separate PR.

I was thinking about property IsCameraPresent. Can make some kind of common interface? Since there are properties in other portals.

I would just make a getIsCameraPresent method. Since portals don't support the org.freedesktop.DBus.Properties interface or have a signal we can't tell if the value changes.

aospiridonov commented 2 years ago

I'm not sure how useful this is without pipewire support in Dart but no harm in implementing.

Yes, dart is not support pipewire. Can you suggest what needs to be done for this? Or make a repository and try to make it together too. If it's relevant of course.

I haven't investigated what we can do with Dart and Pipewire yet, but you're welcome to try!

Okay, I'll try to investigate.

It would be nice to also implement the IsCameraPresent property as well, though that could be in a separate PR.

I was thinking about property IsCameraPresent. Can make some kind of common interface? Since there are properties in other portals.

I would just make a getIsCameraPresent method. Since portals don't support the org.freedesktop.DBus.Properties interface or have a signal we can't tell if the value changes.

Okay, I'll do it. In this PR or in a separate one?

robert-ancell commented 2 years ago

It would be nice to also implement the IsCameraPresent property as well, though that could be in a separate PR.

I was thinking about property IsCameraPresent. Can make some kind of common interface? Since there are properties in other portals.

I would just make a getIsCameraPresent method. Since portals don't support the org.freedesktop.DBus.Properties interface or have a signal we can't tell if the value changes.

Okay, I'll do it. In this PR or in a separate one?

Actually, now I look more closely it does implement org.freedesktop.DBus.Properties - so it should be a Stream<bool>. Let's do it in a separate PR then.