search

canonical / xdg_desktop_portal.dart

Mozilla Public License 2.0
12 stars 6 forks source link

Add Screencast Portal #71

Open aospiridonov opened 2 years ago

aospiridonov commented 2 years ago

Add Screencast Portal

codecov-commenter commented 2 years ago

Codecov Report

Merging #71 (abdb915) into main (efd8e66) will decrease coverage by 2.28%. The diff coverage is 84.07%.

@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
- Coverage   99.04%   96.75%   -2.29%     
==========================================
  Files          16       17       +1     
  Lines         627      740     +113     
==========================================
+ Hits          621      716      +95     
- Misses          6       24      +18
Impacted Files Coverage Δ
lib/src/xdg_screen_cast_portal.dart 83.92% <83.92%> (ø)
lib/src/xdg_desktop_portal_client.dart 92.30% <100.00%> (+0.30%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

aospiridonov commented 2 years ago

Hi @robert-ancell, I think it's necessary to separate the methods call (CreateSession, SelectSources, Start). I am now doing remote desktop portal and I found example xdp-remote-desktop.py where used screen cast methods (SelectSources and PipeWire node id from the method Start ). What do you think about it?