canonical / xdg_desktop_portal.dart

Mozilla Public License 2.0
12 stars 6 forks source link

Add Remote desktop portal #73

Open aospiridonov opened 2 years ago

aospiridonov commented 2 years ago

Add Remote desktop portal

codecov-commenter commented 2 years ago

Codecov Report

Merging #73 (682c4a5) into main (efd8e66) will decrease coverage by 5.22%. The diff coverage is 79.73%.

@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
- Coverage   99.04%   93.81%   -5.23%     
==========================================
  Files          16       18       +2     
  Lines         627      841     +214     
==========================================
+ Hits          621      789     +168     
- Misses          6       52      +46     
Impacted Files Coverage Δ
lib/src/xdg_remote_desktop_portal.dart 73.91% <73.91%> (ø)
lib/src/xdg_documents_portal.dart 91.83% <91.83%> (ø)
lib/src/xdg_desktop_portal_client.dart 93.10% <100.00%> (+1.10%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

robert-ancell commented 2 years ago

This is a big change - I'm not going to be able to review this until https://github.com/canonical/xdg_desktop_portal.dart/pull/71 lands. You might consider breaking off smaller changes into separate PRs that can be more easily reviewed and landed.

robert-ancell commented 2 years ago

I've landed a stub portal commit for this - we can build off that.

aospiridonov commented 2 years ago

This is a big change - I'm not going to be able to review this until #71 lands. You might consider breaking off smaller changes into separate PRs that can be more easily reviewed and landed.

I didn't understand. What should I do for this?

robert-ancell commented 2 years ago

This is a big change - I'm not going to be able to review this until #71 lands. You might consider breaking off smaller changes into separate PRs that can be more easily reviewed and landed.

I didn't understand. What should I do for this?

For example, make a PR with just the getAvailableDeviceTypes() change. That should be quick to review and land. Then continue to do that for the other changes.