Body lookup fails if System/Body name contains a "+" symbol - Githubissues

canonn-science / CAPIv2-Updater

Nodejs based tool to update the Canonn API with planetary and stellar data from EDSM

GNU General Public License v3.0

1 stars 0 forks source link

Body lookup fails if System/Body name contains a "+" symbol #14

Closed derrickmehaffy closed 5 years ago

derrickmehaffy commented 5 years ago

It looks like the url encoder isn't properly encoding the + symbol in a body name thus EDSM returns zero results:

https://www.edsm.net/api-system-v1/bodies?systemName=BD+38%202037 https://www.edsm.net/en/system/bodies/id/18383/name/BD%2B38+2037/details/idB/663256/nameB/BD%2B38+2037+A+1

coldwhitelight commented 5 years ago

This is fixed (and tested) as of https://github.com/canonn-science/CAPIv2-Updater/commit/d1f32f06cecc6b7a4672fe0da2d5809ddf70b3da

derrickmehaffy commented 5 years ago

cool marking as closed