canonn-science / CAPIv2-Updater

Nodejs based tool to update the Canonn API with planetary and stellar data from EDSM
GNU General Public License v3.0
1 stars 0 forks source link

Add main star data to systems updater #23

Open derrickmehaffy opened 5 years ago

derrickmehaffy commented 5 years ago

EDSM endpoint example: https://www.edsm.net/api-v1/system?showId=1&showCoordinates=1&showPrimaryStar=1&systemName=Sol

data example:

{
    "name": "Sol",
    "id": 27,
    "id64": 10477373803,
    "coords": {
        "x": 0,
        "y": 0,
        "z": 0
    },
    "coordsLocked": true,
    "primaryStar": {
        "type": "G (White-Yellow) Star",
        "name": "Sol",
        "isScoopable": true
    }
}

We should dump the main star data similar to how we do for bodies materials/ect

Field on the API is already there, just need to add it to the updater: https://github.com/canonn-science/CAPIv2-Strapi/blob/994f5646c84fa5c98e553c7af38e9700ed6d6b14/api/system/models/System.settings.json#L47-L51

coldwhitelight commented 5 years ago

I would consider using isMainStart:Bool from body or add a 1:1 relation between Bodies (star in this example) and System. No data duplication, and more consistent with current db.