canonn-science / EDMC-Canonn

Project Athens: EDMC plugin to automatically collect accurate science data from the galaxy and coordinate missions
GNU General Public License v3.0
82 stars 12 forks source link

[BUG] Systems with duplicate names can show incorrect POI data #124

Open teptec opened 2 years ago

teptec commented 2 years ago

When getPOIdata calls the query/getSystemPoi endpoint it passes the system name. This is generally fine, but with systems with duplicate names it doesn't return the correct results.

An example is system: 2MASS J03292155+3121104

In system with id 5063630988321, planet 5 has a Thick Methane-rich atmosphere and no biological signals. In system with id 18256696452033, planet 5 has a Thin Neon atmosphere and is home to a Bacterium Acies - Magenta.

Because the API is called with system name, the EDMC plugin reports Bacterium Acies on the Thick Methane-rich body:

image

This is in system 5063630988321: image

But the data for Biology relates to system 18256696452033 where planet 5 has a Neon atmosphere: image

It's worth noting that the canonn-signals page (neon and methane) and the biostats endpoint are passed the Id64 and show correct data. The ideal solution would be to implement a query/getSystemPoiById64 which EDMC-Canonn can call, passing the Id64.

NoFoolLikeOne commented 2 years ago

I intend to switch to spansh at some point and will use the id64 to fetch data and then this will go away

NoFoolLikeOne commented 2 years ago

Need to update plugin to pass id64 to getPOIdata and then only return data if ID64 and SystemName both match