canonn-science / EDMC-Canonn

Project Athens: EDMC plugin to automatically collect accurate science data from the galaxy and coordinate missions
GNU General Public License v3.0
82 stars 12 forks source link

[BUG] Pre-Oddysey bio is only logged correctly by the ship/srv composition scanner #171

Closed DaftMav closed 1 year ago

DaftMav commented 1 year ago

What is your commander name DaftMav

What version are you running EDMC-Canonn-7.0.2

Describe the bug Any Bark Mounds I find do not seem to be logged at all. I'm guessing this has been an issue for years but figured perhaps those were already discovered by someone else. Now that I've found a completely new undiscovered system with Bark Mounds that should definitely have been logged but didn't, I collected all the logs to hopefully help get this fixed.

Last night I found Bark Mounds on body 2 a in this system: Gru Hypue PY-R d4-54 and took samples for Vista Genomics. If you search the Canonn-Alerts discord for that system it should show a few geo and bio discoveries (screenshot) but sadly no bark mounds got recorded. (A scan of body 2 b also indicated to have Bark Mounds but I was not able to find any there.)

However if I search for Bark Mounds on the Canonn-Alerts discord I do see other people getting them logged correctly all the time, so why are mine not being recorded? The other bio/geo seems to get logged just fine too.

And just to point out there's really something going wrong with all of my Bark Mound scans for some reason: According to the Canonn API there's only one time in 2021 when I scanned a Bark Mound: https://api.canonn.tech/bmreports?cmdrName=DaftMav I've definitely scanned a lot more over the years, going to lots of guardian sites etc. and I'm not sure why only that one scan was ever recorded...

Expected behavior Bark Mounds to be logged correctly.

Screenshots System map and Vista Genomics first to log proof. (Full album: https://imgur.com/a/jixB5hV)

Log Files Journal entries related to the Bark Mounds:

{ "timestamp":"2023-03-18T00:27:47Z", "event":"SAASignalsFound", "BodyName":"Gru Hypue PY-R d4-54 2 a", "SystemAddress":1864879640235, "BodyID":17, "Signals":[ { "Type":"$SAA_SignalType_Biological;", "Type_Localised":"Biological", "Count":1 }, { "Type":"$SAA_SignalType_Geological;", "Type_Localised":"Geological", "Count":3 } ], "Genuses":[ { "Genus":"$Codex_Ent_Cone_Name;", "Genus_Localised":"Bark Mounds" } ] }

{ "timestamp":"2023-03-18T00:30:18Z", "event":"ScanOrganic", "ScanType":"Log", "Genus":"$Codex_Ent_Cone_Name;", "Genus_Localised":"Bark Mounds", "Species":"$Codex_Ent_Cone_Name;", "Species_Localised":"Bark Mounds", "SystemAddress":1864879640235, "Body":17 }
{ "timestamp":"2023-03-18T00:36:45Z", "event":"ScanOrganic", "ScanType":"Sample", "Genus":"$Codex_Ent_Cone_Name;", "Genus_Localised":"Bark Mounds", "Species":"$Codex_Ent_Cone_Name;", "Species_Localised":"Bark Mounds", "SystemAddress":1864879640235, "Body":17 }
{ "timestamp":"2023-03-18T00:46:55Z", "event":"ScanOrganic", "ScanType":"Sample", "Genus":"$Codex_Ent_Cone_Name;", "Genus_Localised":"Bark Mounds", "Species":"$Codex_Ent_Cone_Name;", "Species_Localised":"Bark Mounds", "SystemAddress":1864879640235, "Body":17 }
{ "timestamp":"2023-03-18T00:47:00Z", "event":"ScanOrganic", "ScanType":"Analyse", "Genus":"$Codex_Ent_Cone_Name;", "Genus_Localised":"Bark Mounds", "Species":"$Codex_Ent_Cone_Name;", "Species_Localised":"Bark Mounds", "SystemAddress":1864879640235, "Body":17 }

{ "timestamp":"2023-03-18T00:54:20Z", "event":"SAASignalsFound", "BodyName":"Gru Hypue PY-R d4-54 2 b", "SystemAddress":1864879640235, "BodyID":18, "Signals":[ { "Type":"$SAA_SignalType_Biological;", "Type_Localised":"Biological", "Count":1 }, { "Type":"$SAA_SignalType_Geological;", "Type_Localised":"Geological", "Count":3 } ], "Genuses":[ { "Genus":"$Codex_Ent_Cone_Name;", "Genus_Localised":"Bark Mounds" } ] }

EDMC Log shows no errors around the same time of scanning the Bark Mounds either:

2023-03-18 00:28:43.878 UTC - INFO - 3516:10676:10676 plugins.inara.new_worker:1567: sending 3 events for DaftMav
2023-03-18 00:30:29.035 UTC - INFO - 3516:10676:10676 plugins.inara.new_worker:1567: sending 6 events for DaftMav
2023-03-18 00:31:04.189 UTC - INFO - 3516:10676:10676 plugins.inara.new_worker:1567: sending 4 events for DaftMav

2023-03-18 00:36:55.482 UTC - INFO - 3516:10676:10676 plugins.inara.new_worker:1567: sending 9 events for DaftMav

2023-03-18 00:46:51.627 UTC - INFO - 3516:10676:10676 plugins.inara.new_worker:1567: sending 5 events for DaftMav
2023-03-18 00:47:26.804 UTC - INFO - 3516:10676:10676 plugins.inara.new_worker:1567: sending 4 events for DaftMav

2023-03-18 00:55:37.397 UTC - INFO - 3516:10676:10676 plugins.inara.new_worker:1567: sending 3 events for DaftMav

The first error is not until an hour later, but I don't think these are in any way related to the Bark Mounds issue:

2023-03-18 01:35:32.965 UTC - ERROR - 3516:11584:11584 <plugins>.EDMC-Canonn-7.0.2.canonn.emitter.Emitter.send:133: https://api.canonn.tech/reportfsses
2023-03-18 01:35:32.966 UTC - ERROR - 3516:11584:11584 <plugins>.EDMC-Canonn-7.0.2.canonn.emitter.Emitter.send:134: 400
2023-03-18 01:35:32.966 UTC - ERROR - 3516:11584:11584 <plugins>.EDMC-Canonn-7.0.2.canonn.emitter.Emitter.send:137: application/json; charset=utf-8
2023-03-18 01:35:32.967 UTC - ERROR - 3516:11584:11584 <plugins>.EDMC-Canonn-7.0.2.canonn.emitter.Emitter.send:139: {"statusCode": 400, "error": "Bad Request", "message": "The FSS Signal Name: $MULTIPLAYER_SCENARIO77_TITLE; is in our blacklist. You should update your client or talk to the author."}
2023-03-18 01:35:32.968 UTC - ERROR - 3516:11584:11584 <plugins>.EDMC-Canonn-7.0.2.canonn.emitter.Emitter.send:145: {"cmdrName": "DaftMav", "systemName": "Gru Hypue KS-T d3-31", "isBeta": false, "clientVersion": "EDMC-Canonn.7.0.2", "reportStatus": "pending", "systemAddress": 1074588880547, "signalName": "$MULTIPLAYER_SCENARIO77_TITLE;", "signalNameLocalised": "Resource Extraction Site [Low]", "spawningState": null, "spawningStateLocalised": null, "spawningFaction": null, "rawJson": {"timestamp": "2023-03-18T01:35:31Z", "event": "FSSSignalDiscovered", "SystemAddress": 1074588880547, "SignalName": "$MULTIPLAYER_SCENARIO77_TITLE;", "SignalName_Localised": "Resource Extraction Site [Low]"}}

Which seems related to these journal entries:

{ "timestamp":"2023-03-18T01:35:31Z", "event":"FSSSignalDiscovered", "SystemAddress":1074588880547, "SignalName":"$MULTIPLAYER_SCENARIO14_TITLE;", "SignalName_Localised":"Resource Extraction Site" }
{ "timestamp":"2023-03-18T01:35:31Z", "event":"FSSSignalDiscovered", "SystemAddress":1074588880547, "SignalName":"$MULTIPLAYER_SCENARIO77_TITLE;", "SignalName_Localised":"Resource Extraction Site [Low]" }
{ "timestamp":"2023-03-18T01:35:31Z", "event":"FSSSignalDiscovered", "SystemAddress":1074588880547, "SignalName":"$MULTIPLAYER_SCENARIO42_TITLE;", "SignalName_Localised":"Nav Beacon" }
{ "timestamp":"2023-03-18T01:35:31Z", "event":"FSSSignalDiscovered", "SystemAddress":1074588880547, "SignalName":"DEATHBRINGER [GMSD] Q1T-9KK", "IsStation":true }
{ "timestamp":"2023-03-18T01:35:31Z", "event":"FSSDiscoveryScan", "Progress":0.207862, "BodyCount":37, "NonBodyCount":16, "SystemName":"Gru Hypue KS-T d3-31", "SystemAddress":1074588880547 }
DaftMav commented 1 year ago

Just saw a discussion on discord in #software about brain trees not registering and apparently it's because the plug-in only looks at ship scans and can't tell variants from certain scans? So I went back to scan the damn Bark Mounds with the ship composition scanner and now it did get logged... 🤦‍♂️

{ "timestamp":"2023-03-18T22:30:18Z", "event":"CodexEntry", "EntryID":2100301, "Name":"$Codex_Ent_Cone_Name;", "Name_Localised":"Bark Mounds", "SubCategory":"$Codex_SubCategory_Organic_Structures;", "SubCategory_Localised":"Organic structures", "Category":"$Codex_Category_Biology;", "Category_Localised":"Biological and Geological", "Region":"$Codex_RegionName_9;", "Region_Localised":"Inner Scutum-Centaurus Arm", "System":"Gru Hypue PY-R d4-54", "SystemAddress":1864879640235, "BodyID":17, "Latitude":-30.768759, "Longitude":19.637733 }

Leaving this open because imho this is still a bug or at least a flaw/oversight. Who still scans with the ship when you're doing biology scans on foot? It should register either way, it does correctly log other bio on foot so that's how most people would expect it to work no?

Afaik Bark Mounds do not have any variants anyway so those should log with either scan type. And for Braintrees and Anemones should it not still log that an unknown variant of X is found? And update it with the variant if a ship scan is done later? Perhaps there should be a notification from the plug-in to let you know you have to scan these things with the ship to actually get them logged properly.

Just saying I think most people will never know about this quirk and scan bio with the genetic sampler on foot.

NoFoolLikeOne commented 1 year ago

Glad I procrastinated on this one because Fdev have added Variant into the organic scan event so I have integrated that.