canonn-science / EDMC-Canonn

Project Athens: EDMC plugin to automatically collect accurate science data from the galaxy and coordinate missions
GNU General Public License v3.0
82 stars 12 forks source link

[BUG] Cannon plugin link to Signal page for a system is a broken link. #178

Closed TonyFlury closed 1 year ago

TonyFlury commented 1 year ago

What is your commander name Flury

What version are you running 7.1.1

Describe the bug Link to Cannon Challenge page for HIP 115991 gives a broken link :

The plugin provides a link to "https://tools.canonn.tech/Signals/?system=HIP 115991" (without the quotes), which results in a page not found error.

To Reproduce In the Cannon plugin, get a link to HIP 115991

Expected behavior It should link to "https://tools.canonn.tech/signals/?system=HIP%20115991" which works as expected.

Note that the correct link has a lower case 'S' in "signals", whereas the plugin gives an upper case S.

Screenshots image

Log Files

Additional context

TonyFlury commented 1 year ago

Additional :screenshot showing the correct link (lower case s)

image

NoFoolLikeOne commented 1 year ago

Sorry it too so long. This should now be fixed