Event excludes ignoring a few

canonn-science / EDMC-Canonn

Project Athens: EDMC plugin to automatically collect accurate science data from the galaxy and coordinate missions

GNU General Public License v3.0

80 stars 12 forks source link

Event excludes ignoring a few #30

Closed derrickmehaffy closed 5 years ago

derrickmehaffy commented 5 years ago

What version are you running Reporting on behalf of other users, but based on reports EDMC-Canonn.1.9.1

Describe the bug Shutdown event is in the excludes list but is still being sent

To Reproduce Example: https://api.canonn.tech:2083/reportevents?eventname=Shutdown

Expected behavior Shutdown should not be sent to the CAPI as we don't need to store the data.

Screenshots N/A

Log Files No logs as this is reported from our side

Additional context N/A

NoFoolLikeOne commented 5 years ago

Change the code to populate a local exclusions list and then when complete this can be copied to the cls.exclusions and this should prevent other threads from reading the data before it is complete.

NoFoolLikeOne commented 5 years ago

Need to update the exclusions spreadsheet

ShutDown -- listed as Shutdown in the sheet
Statistics -- contains player stats. We will want our own model for that

NoFoolLikeOne commented 5 years ago

I've only seen evidence of typos and missing events so far