search

canselcik / libremarkable

The only public framework for developing applications with native refresh support for Remarkable Tablet
MIT License
616 stars 56 forks source link

Make framebuffer_update public #100

Closed LinusCDE closed 2 years ago

LinusCDE commented 2 years ago

I need this variable to be public, since you can't rotate the framebuffer in hardware otherwise (rm 1 only). Thought I could get away with a new instance, but since the new instance re initializes my changed data (and resets the rotation value), it wouldn't work that way.

On the rM 2, I know do this in software (was disabled there until now) but for the rM 1 I prefer to let the hardware do the pixel transformation.

Another solution to this would be to implement this as part of a new function to update the fix_screen_info. But I recon nobody except me will ever need this, and it might sound weird to "update fixed info". But I have no problems doing this instead if preferred.

bkirwi commented 2 years ago

Yeah... it would be nice to have better abstractions here, and maybe we'll get to it someday, but this seems like the right call in the meantime. Thanks!