search

canselcik / libremarkable

The only public framework for developing applications with native refresh support for Remarkable Tablet
MIT License
616 stars 56 forks source link

Prevent usage newer evdev than 0.11.3 due to compilation error for armv7 #107

Closed LinusCDE closed 2 years ago

LinusCDE commented 2 years ago

This should fix issue #106 by capping the version of evdev used for now.

I also tested with the newer minor version (0.12.0) and it had the same issue as well.

LinusCDE commented 2 years ago

Was about to make a PR to evdev to fix the source issue, but found that their current master branch builds fine. It seems this already got addressed in a commit 9 days ago, but there is no release with this fix yet.

PR: https://github.com/emberian/evdev/pull/96 Commit: https://github.com/emberian/evdev/commit/909b3d2f53fae43f5ed42ece5a22d37a797edf38

So this fix should do the trick until the next release of evdev fixes the issue. If it's a patch release (0.12.X) we should probably use >= for the version to ensure no accidental use of 0.12.0.

Will merge this tomorrow of no one is against this (cc @bkirwi @fenollp )

bkirwi commented 2 years ago

I'm all for it - thanks for handling!

On Thu, Sep 1, 2022 at 08:05 Linus K. @.***> wrote:

Was about to make a PR to evdev to fix the source issue, but found that their current master branch builds fine. It seems this already got addressed in a commit 9 days ago, but there is no release with this fix yet.

PR: emberian/evdev#96 https://github.com/emberian/evdev/pull/96 Commit: @.*** https://github.com/emberian/evdev/commit/909b3d2f53fae43f5ed42ece5a22d37a797edf38

So this fix should do the trick until the next release of evdev fixes the issue. If it's a patch release (0.12.X) we should probably use >= for the version to ensure no accidental use of 0.12.0.

Will merge this tomorrow of no one is against this (cc @bkirwi https://github.com/bkirwi @fenollp https://github.com/fenollp )

— Reply to this email directly, view it on GitHub https://github.com/canselcik/libremarkable/pull/107#issuecomment-1234180372, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMFXMZUBEYVP5UGP6LM27DV4CLEXANCNFSM6AAAAAAQCI2EDA . You are receiving this because you were mentioned.Message ID: @.***>