cantaloupe-project / cantaloupe

High-performance dynamic image server in Java
https://cantaloupe-project.github.io/
Other
270 stars 111 forks source link

Upgrade maven-assembly-plugin to fix CVE-2023-37460 in plexus-archiver #673

Closed camille-hdl closed 3 months ago

camille-hdl commented 3 months ago

Hello,

I'm trying to fix this vulnerability in Cantaloupe 5 (and future versions obviously).
I'm not a Java developer so I'm a bit lost in the tooling but I tried to change the version number here : https://github.com/camille-hdl/cantaloupe-upgrade-maven-assembly/commit/a2cdd0f0fa3f12dabb8ed57a909d7b7d90b02714

I saw previous work done on fixing vulnerabilities in the dependencies in #634 , but apparently there was no acceptable release of maven-assembly-plugin available at the time. I believe there is one now (3.7.1 or 3.7.0).

I started by branching off of develop and ran the CI workflow on my own repo, which seemed to work at least for the windows builds. I then branched off of release/5.0 and will submit a PR shortly.

As I said, I'm not used to the Java ecosystem (or contributing to other projects on GitHub in general), so I apologize if I did this the wrong way and I'm willing to try again should anyone be willing to offer me guidance.

Thank you for your work on Cantaloupe

Camille

glenrobson commented 3 months ago

Fixed in #675