search

cantineNantes / mustached-robot

Mustached Robot is an open-source checkin plateform for coworking spaces (currently under development).
http://www.mustached-robot.org
11 stars 4 forks source link

Checkin button is spammable ~ Breaking statistics #24

Closed ghost closed 12 years ago

ghost commented 12 years ago

Hi,

I just noticed that the checkin button is spammable (no timer) I think it should be a good idea to add a condition which checks that the user's last checkin was "X time ago" to re-checkin again, otherwise if an user has some lags when he is clicking and clicks again, it will be a mess in the statistics...

Youri SVAHN

dzey commented 12 years ago

True! Thanks for finding this one.

The time-out solution is a good idea, but it would require to be a settings configured by the admin and it may not cover all the business need of coworking spaces (some may be billable by the hour, other by half-day, so what happens if someone checks in at 11am and checks in agains at 14pm?).

It may be more simple (and cover all the business needs of coworking spaces) to allow a user to checkin if he has hasn't any other checkin still active for the current day. There is a field called "killed" meaning the checkin is no more active (a checkin can only be killed by an admin). To know the date of the checkin, we use created_at.

Would you like to fix this bug?

fgosselin commented 12 years ago

Little up here! :)

dzey commented 12 years ago

Well, I can take it unless @ysvahn has already started / wants to fix it.

ghost commented 12 years ago

Oh, my bad, I am kinda busy right now, we are moving of our old building for a new one, so it's a little messed up. We just released our new website and I have some amount of work to do :( You can fix it if you want, I think I won't be able to do it in the next days, and this is a boring bug.

Sorry for the delay !