search

cantino / jsoneditor

JavaScript widget for inline JSON editing
MIT License
47 stars 10 forks source link

Flexible-height editor #1

Closed peter-x closed 10 years ago

peter-x commented 10 years ago

I noticed that the "create agent"-button in huginn is always placed a bit below the JSONEditor for the options. As it happens, it is just below the page height on my computer, and it took me some time to find it for the first time :-) Is there a reason for the height of the JSONEditor to be fixed? I removed all the parts that set the height and it seems to work perfectly.

cantino commented 10 years ago

Hey @peter-x. Interestingly, I was just getting annoyed with this myself and looking into fixing it. I don't think there's any compelling reason that it needs to be fixed height. I'll try to upgrade this library and Huginn's usages of it to have flexible heights sometime this week.

peter-x commented 10 years ago

Cool, thanks! While you are at it: Could you also set the font-family of the textarea to monospace in huginn?

cantino commented 10 years ago

Yes!

peter-x commented 10 years ago

Thanks!