cantino / mcfly

Fly through your shell history. Great Scott!
MIT License
6.87k stars 177 forks source link

Do not set HISTCONTROL if it is already set #109

Closed CreativeCactus closed 3 years ago

CreativeCactus commented 3 years ago

This depends on #105 (and fixes for bash <4) to some extent: If HISTCONTROL is set in such a way that ignorespace is not implied, #mcfly: debris will pollute history. This is not as bad as it seems, becuase it is still be possible for users to create this issue by setting a bad HISTCONTROL after loading mcfly.bash in their .bashrc.

Otherwise, checks can be added for specific $HISTCONTROL values. In my case, my ignoreboth (which implies ignorespace) was being overwritten.

cantino commented 3 years ago

Thanks!