Don't create a tarbomb - Githubissues

cantino / mcfly

Fly through your shell history. Great Scott!

MIT License

6.85k stars 178 forks source link

Don't create a tarbomb #141

Open barmic opened 3 years ago

barmic commented 3 years ago

tarbomb (archive without folder) is generaly a bad practice.

Instead of:

mcfly
mcfly.bash
mcfly.fish
mcfly.zsh

this will create:

mycfly
- mcfly
- mcfly.bash
- mcfly.fish
- mcfly.zsh

I'm not sure of all impact of it (for hombrew for example).

cantino commented 3 years ago

Thanks @barmic! However, I think this might break Homebrew and users' install scripts.

necaris commented 1 year ago

@barmic if you still have the energy to look at it, it would be great if this PR also included the changes to the Homebrew recipe and install documentation to go with the changed folder structure in the zip file.