search

cantino / mcfly

Fly through your shell history. Great Scott!
MIT License
6.78k stars 177 forks source link

Command is not passed back to bash when connected over SSH #192

Open arjan-s opened 2 years ago

arjan-s commented 2 years ago

When I connect using SSH to a server where mcfly is installed, passing back the selected command to bash doesn't work. Pressing Enter or Tab both just return me to bash without the command executed or visible. This works fine on my local workstation, but not after SSH'ing to my server which runs exactly the same software.

Software details: Arch Linux Bash 5.1.8 Powerline-go 1.21.0 (although I have the same problem without powerline-go)

Also, I couldn't find documentation or tips on how to debug these kind of issues. Perhaps that would be a good addition to the readme?

jamedeus commented 1 month ago

Same issue on Bash 5.2.21 and Ubuntu server 24.04. Mcfly suggests commands like normal, but whether enter or tab is pressed it just goes back to a blank prompt without running anything.

I initially thought this might be calling the locally-installed mcfly on my dev machine instead of the one installed on the server. I can confirm that it is the server install by first SSHing to a machine without mcfly (Ctrl+R shows vanilla reverse search), and then from there SSHing to the server with mcfly (Ctrl+R shows mcfly, but tab/enter don't work).

cantino commented 1 month ago

Likely this is #333?

jamedeus commented 1 month ago

Could be related, but I'm not sure. The working dev machine is on kernel 6.5 while the server (not working) is 6.8, and neither have CONFIG_LEGACY_TIOCSTI. I should have some time to test and narrow this down tomorrow.

jamedeus commented 1 month ago

I did some testing and my issue seems to be #333 after all. I connected a display to the server and the same issue occurs without SSH, and building the avoid TIOCSTI PR fixed it. Still not sure why it works on my dev machine but debugging kernel config is a bit over my head.