cantino / mcfly

Fly through your shell history. Great Scott!
MIT License
6.77k stars 176 forks source link

normal `reverse-search-history` break after uninstalling mcfly #231

Closed ahmad-elkomy closed 2 years ago

ahmad-elkomy commented 2 years ago

I have used mcfly for over a month now and bash keeps crashing pretty frequently. Now I decided to uninstall the program so I commented out eval "$(mcfly init bash)" from by ~/.bashrc and restarted the machine.

Now, whenever I try to use ctrl-r, the normal built-in reverse-search-history, I still get a list of suggestions, and even when I pick one, the terminal crashes/exists.

(reverse-i-search)`git cl': exit                                                                              
exit
cd /home/ahmad.elkomey
cd /home/ahmad.elkomey
cd /home/ahmad.elkomey
cd /home/ahmad.elkomey
cd /home/ahmad.elkomey
cd /home/ahmad.elkomey
sudo apt autoremove
git clean -df --exclude="*legacy"
git status
git status
git pull
git log

Is there something I am missing? I think this is a bug. mcfly broke how reverse-search-history functionality it seems.

cantino commented 2 years ago

Sorry to hear you're having crashes, but if you're no longer sourcing mcfly init bash, mcfly isn't running. You could check for any MCFLY_* environment variables being set in env as a way to double check.

ahmad-elkomy commented 2 years ago

Yes. Thank you! Unsetting all MCFLY env variables solved it.