Iss226 - Copy Highlighted Command to system clipboard

[navazjm]

Closes #226

As discussed in issue 226, I installed the rust-clipboard crate to easily add text to the system clipboard. I updated the menu interface text to display the new keybinding for the user to know which keys to press to copy the selected command. I decided to use 'Ctrl+y' in both emacs and vim keybindings. I could not use the default keybindings from either one, so I decided it would be best to use the same keybinding for both. Also, I decided that the user should be able to use the keybinding in both insert and command mode of vim.

Love to hear your feedback @cantino 🤘🏼

[cantino]

Thanks @michaelnavs, this is a cool feature! I just tested it and it worked on my Mac. A few thoughts:

• Do you think we should use a function key for copy instead of ctrl-y? I'm honestly not sure, I'd be okay with either but then it would match delete.
• I think it should provide some visible feedback when you copy, to let you know that it worked.
• Have you tested on Windows / Linux?

[navazjm]

• I honestly didn't even think about using a function key, but it is a good idea since it would be consistent for all keybindings and match the delete command. Plus, it would clean up the menu interface UI.
• I thought about the adding some feedback, but I don't know how you would want that to be implemented. If you have any ideas, I would be more than happy to add it.
• I am also on Mac, so I know it works on Mac. I have a windows machine and can test it, but I won't be able to do it until Sunday as I will be out of town until then. I do not have a way to test directly on Linux, but I can install a vm and test it if would like me to.

[navazjm]

Tested on Linux (Ubuntu), worked as expected. It behaves just like MacOS. Tested it on Windows with WSL Ubuntu and I run into an error on startup.

The error comes from:

    pub fn new(settings: &'a Settings, history: &'a History) -> Interface<'a> {
        Interface {
            history,
            settings,
            input: CommandInput::from(settings.command.to_owned()),
            selection: 0,
            matches: Vec::new(),
            debug: settings.debug,
            run: false,
            delete_requests: Vec::new(),
            menu_mode: MenuMode::Normal,
            in_vim_insert_mode: true,
            clipboard_context: ClipboardProvider::new().unwrap(), // error here
        }
    }

[cantino]

Did that happen on boot, or only when you tried to copy?

[navazjm]

It happens on boot

[cantino]

I think we need to defer calling ClipboardProvider::new().unwrap() until the user actually tries to copy, that way the crash is limited to that UI interaction.