cantino / mcfly

Fly through your shell history. Great Scott!
MIT License
6.77k stars 176 forks source link

Install script attempts to download aarch64-unknown-linux-musl when run on 64 Raspberry Pi #253

Closed upyesp closed 2 years ago

upyesp commented 2 years ago

Hi, I have mcfly working great on a number of Linux machines.

I'm trying to install it on a Raspberry Pi running a 64bit OS. I see from previous posts people have installed mcfly on Pis successfully, using the Armv7 version. When I try this (or any Arm version), I get a "file not found" error. I believe I have the path set correctly and the file is being found, but that it is not executable on 64bit Raspberry Pi OS.

I have also tried running the standard install script. This fails when it attempts to download:

aarch64-unknown-linux-musl

So it appears an aarch64 version is required for 64bit Pi OS?

Is an aarch64 version available?

Thanks

cantino commented 2 years ago

I don't think we're currently building one. @praveenperera, is this an easy change?

praveenperera commented 2 years ago

@cantino I will enable building aarch64-unknown-linux-musl, I'll make a PR

upyesp commented 2 years ago

That's great news! Thanks!

cantino commented 2 years ago

Should be fixed now. Can you please confirm?

upyesp commented 2 years ago

Working great on Raspberry Pi OS 64bit!!!

Thanks!

praveenperera commented 2 years ago

Hey @upyesp the aarch-64 builds will be created on the next release. And jq won’t be needed for the install script after #258

upyesp commented 2 years ago

That's great, thanks @praveenperera.