search

cantino / mcfly

Fly through your shell history. Great Scott!
MIT License
6.89k stars 178 forks source link

re-enable aarch64-apple-darwin tests #260

Closed adamcstephens closed 2 years ago

adamcstephens commented 2 years ago

Testing re-enabling these. It has been over a year since https://github.com/cantino/mcfly/commit/6e158015f1c9a535907b0454c2b190366b3866ed disabled them, so maybe try again ?

cantino commented 2 years ago

Just kicked it off.

adamcstephens commented 2 years ago

Ahh, didn't realize I needed permissions for every actions run. I'll switch to running these on my fork.

adamcstephens commented 2 years ago

I'm not sure of a good path forward for aarch64-apple-darwin tests. The binary is cross compiled but the tests fail because they can't run on a different architecture.

I'd love to see releases built for aarch64-apple-darwin, but would you even consider that without functioning tests?

Closing this PR.

cantino commented 2 years ago

@praveenperera, do you have any ideas?

praveenperera commented 2 years ago

Unfortunately this issue is still open. https://github.com/actions/virtual-environments/issues/2187

I’ve been tracking it, GitHub was ignoring it for a long time. Recently, they said it’s been added to the roadmap. So hopefully soon.

Also see: https://github.com/rust-lang/rust/issues/73908

adamcstephens commented 2 years ago

I am tracking the same issues. Sadly I haven't found any good solutions for aarch64-darwin, and most of the rust community seems to be blocked by GitHub (and Apple?).

Cross platform for Linux has matured quite well and it's trivial to use binfmt stubs plus docker to achieve non amd64 support.

cantino commented 2 years ago

Released in 0.6.1!

adamcstephens commented 2 years ago

@cantino I'm not seeing aarch64-Darwin builds. Did you mean for there to be?

cantino commented 2 years ago

Sorry for the confusion. No, I wouldn't expect this to be fixed because of https://github.com/actions/virtual-environments/issues/2187