cantino / mcfly

Fly through your shell history. Great Scott!
MIT License
6.76k stars 176 forks source link

Feature Request: New way of displaying hotkeys #305

Open navazjm opened 1 year ago

navazjm commented 1 year ago

As more features for different hotkeys are being added in, eventually we will run out of screen real estate to display all hotkeys.

Screenshot 2022-11-30 at 6 39 45 PM

My first proposal is that we add a new hotkey that will open another termion alternate screen to display a table of hotkeys and their related action. Pressing the same hotkey will close this alternate screen and go back to the main McFly screen. My second proposal is that we remove all the hotkeys from the menu bar and create a fixed hotkey table at the bottom of the screen. The only issue I see with this one is we probably would need to look into removing MCFLY_INTERFACE_VIEW=BOTTOM. Also, the other caveat to this solution is displaying ALL hotkeys on the main screen will clutter the UI in the future if there are too many hotkeys.

Upon further testing, the menubar will wrap text if it exceeds the terminal width. I mention this because this will cause any issue once the menubar exceeds two lines in length.

Screenshot 2022-11-30 at 10 00 21 PM

cantino commented 1 year ago

We could also test for screen width and hide options as the screen gets narrower, perhaps?