cantino / mcfly

Fly through your shell history. Great Scott!
MIT License
6.76k stars 176 forks source link

option to change color theme #316

Closed brunoamaral closed 1 year ago

brunoamaral commented 1 year ago

I use Oh my Zsh, and the results are hard to read:

image
cantino commented 1 year ago

Have you tried export MCFLY_LIGHT=TRUE?

brunoamaral commented 1 year ago

thank you for replying @cantino 🙂

yes, this is my .zshrc

eval "$(mcfly init zsh)"
export MCFLY_LIGHT=TRUE

edit: also tried to set the variable first and eval mcfly after

cantino commented 1 year ago

And I assume turning off MCFLY_LIGHT also looks bad?

On Fri, Dec 16, 2022 at 2:44 AM Bruno Amaral @.***> wrote:

thank you for replying @cantino https://github.com/cantino 🙂

yes, this is my .zshrc

eval "$(mcfly init zsh)"

export MCFLY_LIGHT=TRUE

— Reply to this email directly, view it on GitHub https://github.com/cantino/mcfly/issues/316#issuecomment-1354540179, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAUO6YYLPJ3FT3K2655QVTWNRBXXANCNFSM6AAAAAAS7SJ6SQ . You are receiving this because you were mentioned.Message ID: @.***>

brunoamaral commented 1 year ago

it doesn't seem to have any effect. At first I was just running the eval command, and I guess MCFLY_LIGHT=FALSE is the default?

image
cantino commented 1 year ago

I actually think the default is MCFLY_LIGHT being unset. Try commenting it out and seeing how it looks.

brunoamaral commented 1 year ago

You're right, it look legible now. Thank you!

image
cantino commented 1 year ago

Great! We should make that env smarter, FALSE probably shouldn’t be treated as TRUE. 😆

On Tue, Dec 20, 2022 at 4:27 AM Bruno Amaral @.***> wrote:

You're right, it look legible now. Thank you! [image: image] https://user-images.githubusercontent.com/543344/208667062-205b5e48-4d1e-4e7a-b7f0-1d8b857f776d.png

— Reply to this email directly, view it on GitHub https://github.com/cantino/mcfly/issues/316#issuecomment-1359285437, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAUO6YYDGO4MOZKHEI2NCLWOGQ3DANCNFSM6AAAAAAS7SJ6SQ . You are receiving this because you were mentioned.Message ID: @.***>

cantino commented 1 year ago

I'll fix this in https://github.com/cantino/mcfly/pull/319. Thanks :)

chr1shung commented 6 months ago

I'm having similar issue:

截圖 2023-12-13 14 36 50

I tried MCFLY_LIGHT=true and the result is worse, any idea how to make it more visible ? thanks

cantino commented 6 months ago

And I assume MCFLY_LIGHT=false also doesn't work?

chr1shung commented 6 months ago

And I assume MCFLY_LIGHT=false also doesn't work?

It's not working neither. I found out the reason might have something to do with my alacritty(terminal) theme, right now the workaround is to change the theme and it'll display normally.

miloszwatroba commented 4 months ago

Also having issues when using with alacritty. Any luck resolving the issue @chr1shung without changing the alacritty's theme?

chr1shung commented 4 months ago

@miloszwatroba unfortunately no :( What alacritty theme are you using btw ?

miloszwatroba commented 4 months ago

tomorrow_night from https://github.com/alacritty/alacritty-theme