cantino / mcfly

Fly through your shell history. Great Scott!
MIT License
6.75k stars 176 forks source link

Add option to disable command running #334

Closed chaserhkj closed 1 year ago

chaserhkj commented 1 year ago

This patch adds a new option MCFLY_DISABLE_RUN_COMMAND, which disables all command runs in mcfly when enabled.

This is related to #284 - I have been using fzf-history for quite a while and have built muscle memory of using enter to select a history command line and edit it. Since I switched to mcfly, the new enter key to select and execute a command may accidentally fire up unexpected command runs. This had made a lot of close calls to me already - dangerous history commands like rm and removal API calls.

It's really hard to adapt after years of usage. So I think it might make sense to add an option to mcfly that could globally turn off any command runs to avoid any surprises. This should help others who are migrating from fzf-hisory as well.

cantino commented 1 year ago

Released in v0.8.0.