search

cantino / mcfly

Fly through your shell history. Great Scott!
MIT License
6.75k stars 176 forks source link

Added basic customisation for menubar colors #343

Open V1RE opened 1 year ago

V1RE commented 1 year ago

156 looks promising, but hasn't seen much action in the last 2 years. So I

made a quick and simple way to customize the foreground and background colors of the menubar using env vars.

Haven't used rust too much, so lmk if I can improve on anything

cantino commented 1 year ago

Thanks @V1RE! The only problem is if we merge this, we need to support these options even in an eventually, more configurable world. Perhaps thats fine though.

cantino commented 1 year ago

Do you want to go through and wire up other color options too (text, background, highlight)?

V1RE commented 1 year ago

Sure, what env vars should I use?

cantino commented 1 year ago

MCFLY_PROMPT_COLOR, MCFLY_HIGHLIGHT_COLOR, MCFLY_SELECTION_COLOR might be all of them?

V1RE commented 1 year ago

@cantino What to do with the lightmode setting? this would kind of make that obsolete, right?

cantino commented 2 weeks ago

Can we integrate this with the new configuration system https://github.com/cantino/mcfly/pull/407?