cantino / mcfly

Fly through your shell history. Great Scott!
MIT License
6.75k stars 176 forks source link

Fish’s private mode #354

Closed Aeron closed 1 year ago

Aeron commented 1 year ago

The question is simple: should McFly automatically respect Fish’s private mode? Because, at this point, it doesn’t, so anything you type in private mode goes to MyFly’s database, while Fish’s history stays clear of it.

The fix is simple since there’s an environment variable for that. Yet an emphasis here is on automatically. Should a user consciously decide to forbid and manually implement it in the config, or should it be enabled by default?

I’ll gladly implement the default option if the community agrees to it.

cantino commented 1 year ago

I wasn't aware of Fish's private mode. That's a great question. If fish's history avoids recording commands in private mode, we probably should too. I'd be glad to accept a PR.

Aeron commented 1 year ago

Got it. I’ll get to it then 👍