search

cantino / mcfly

Fly through your shell history. Great Scott!
MIT License
6.75k stars 176 forks source link

Drop custom homebrew tap #379

Closed tisba closed 7 months ago

tisba commented 7 months ago

See https://github.com/cantino/mcfly/issues/122

As discussed in https://github.com/cantino/mcfly/issues/122 the custom homebrew tap can probably just be dropped. This is just a suggestion, @cantino :)

I'm not quite sure how Homebrew does updates to bottled Formula these days. mcfly's Formula lives at https://github.com/Homebrew/homebrew-core/blob/master/Formula/m/mcfly.rb. There is brew bump-formula-pr which should probably do most of the work, I haven't used it in a while though (see https://docs.brew.sh/How-To-Open-a-Homebrew-Pull-Request#submit-a-new-version-of-an-existing-formula).

I -think- all you have to do is (with the version replaced obviously):

brew bump-formula-pr --url https://github.com/cantino/mcfly/archive/refs/tags/v0.8.1.tar.gz mcfly
praveenperera commented 7 months ago

Turns out out brew uses custom self-hosted runners, @cantino lets merge this.

https://brew.sh/2022/09/15/homebrew-maintainer-projects-update/

cantino commented 7 months ago

Thanks @praveenperera, but I'm a little unclear on what I need to do. After having merged this, how do I update homebrew when I do a GitHub release? Just the brew bump-formula-pr command or do we need to integrate a runner somehow too?

praveenperera commented 7 months ago

@cantino I think we just take out the custom tap and let home-brew make updates. Seems like they update their tap automatically. https://github.com/Homebrew/homebrew-core/pull/147318

And if not we can make a PR in their repo.

cantino commented 7 months ago

Okay let's try it.

cantino commented 7 months ago

And remove cantino/homebrew-mcfly too?

cantino commented 7 months ago

See revert, I need to think about this and test it a bit more.

cantino commented 6 months ago 
➜  mcfly git:(master) ✗ brew bump-formula-pr --url https://github.com/cantino/mcfly/archive/refs/tags/v0.8.3.tar.gz mcfly
Error: No available formula with the name "mcfly".
➜  mcfly git:(master) ✗ brew bump-formula-pr --url https://github.com/cantino/mcfly/archive/refs/tags/v0.8.3.tar.gz cantino/mcfly
Error: No available formula with the name "cantino/mcfly".

Ideas?