cantino / mcfly

Fly through your shell history. Great Scott!
MIT License
6.75k stars 176 forks source link

Draft releases messed up #391

Closed cantino closed 6 months ago

cantino commented 6 months ago

@praveenperera it looks like each package is going into a different draft release now, I don't think due to any change on our part. Have you seen this before? https://github.com/cantino/mcfly/releases

suzuki-shunsuke commented 6 months ago

v0.8.4 doesn't have pre-built binaries for linux.

https://github.com/cantino/mcfly/releases/tag/v0.8.4

image

It seems builds succeeded.

https://github.com/cantino/mcfly/actions/runs/7317302030/job/19932679935

Run actions/upload-release-asset@v1
  with:
    upload_url: https://uploads.github.com/repos/cantino/mcfly/releases/135022051/assets{?name,label}
    asset_path: mcfly.tar.gz
    asset_name: mcfly-v0.8.4-aarch64-unknown-linux-gnu.tar.gz
    asset_content_type: application/gzip
  env:
    BIN: mcfly
    GITHUB_TOKEN: ***

Is this issue related? Or different issue?

cantino commented 6 months ago

@suzuki-shunsuke Does it have what you need now? https://github.com/cantino/mcfly/releases/tag/v0.8.4

I think it just took time to process.

praveenperera commented 6 months ago

@cantino I ran the action again, that seems to have done it. I think I just need to disable the CD for draft releases, making a PR.

suzuki-shunsuke commented 6 months ago

Thank you both!