cantino / mcfly

Fly through your shell history. Great Scott!
MIT License
6.87k stars 176 forks source link

mcfly does not show recently executed commands #88

Closed utdrmac closed 3 years ago

utdrmac commented 4 years ago

I'm not sure if this is an issue with my terminal config or issue with mcfly. I can type a command, execute command, then immediately attempt to search (ctrl-r) for the command I just executed and it's nowhere to be found in mcfly. Why isn't mcfly sorting commands based on most-recently executed? I absolutely love the "context awareness" because some commands I only run from specific directories and those always show up first. But I'm in a different dir now, and I just ran a command, and it's not appearing in mcfly.

cantino commented 4 years ago

Hey @utdrmac. Do you not see it, even if you search for the command string itself? Or is it just not on the first page of default results?

utdrmac commented 4 years ago

I see it, it's just not #1 on the list. I would expect the command I just typed to be at the top of the list since I'm still in the same directory.

cantino commented 4 years ago

That's not how mcfly works. Since you can just hit the up arrow to run the most recent command, mcfly prioritizes commands that are less accessible, but still likely to be relevant. It's algorithm certainly isn't perfect, though.

dchatterjee172 commented 4 years ago

@cantino just faced a strange issue, the up arrow is somehow showing command prioritized by mcfly,

debajyoti@abs ~/sd (sd)(sd)
git --version
git version 2.27.0
debajyoti@abs ~/sd (sd)(sd)
source ~/.bashrc

When I pressed up key I got source ~/.bashrc instead of git --version

which also comes up when I press ctrl-r

McFly | ESC - Exit | ⏎ - Run | TAB - Edit | F2 - Delete

$ source ~/.bashrc

source ~/.bashrc
cantino commented 4 years ago

Up arrow doesn't interface with mcfly, I think that's a coincidence.

On Wed, Jul 8, 2020 at 8:53 PM Debajyoti Chatterjee < notifications@github.com> wrote:

@cantino https://github.com/cantino just faced a strange issue, the up arrow is somehow showing command prioritized by mcfly,

debajyoti@abs ~/sd (sd)(sd)

git --version

git version 2.27.0

debajyoti@abs ~/sd (sd)(sd)

source ~/.bashrc

When I pressed up key I got source ~/.bashrc instead of git --version

which also comes up when I press ctrl-r

McFly | ESC - Exit | ⏎ - Run | TAB - Edit | F2 - Delete

$ source ~/.bashrc

source ~/.bashrc

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cantino/mcfly/issues/88#issuecomment-655882891, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAUO6ZX5JJDJMJF2FWYRW3R2U5K5ANCNFSM4OPHORFA .