search

cantino / ruby-readability

Port of arc90's readability project to Ruby
Apache License 2.0
919 stars 170 forks source link

Use XHTML serialization instead of HTML #47

Closed gioele closed 11 years ago

gioele commented 11 years ago

Ask Nokogiri to serialize output as XHTML instead of HTML. Such output is compatible with HTML 4, HTML 5 and XML while the HTML-only serialization is not compatible with XML.

cantino commented 11 years ago

Hey @gioele, this broke the build: https://travis-ci.org/cantino/ruby-readability/jobs/5932072

Can you fix it?

gioele commented 11 years ago

The first two failures

  1. rspec ./spec/readability_spec.rb:41 # Readability images should show one image, but outside of the best candidate
  2. rspec ./spec/readability_spec.rb:317 # Readability the cant_read.html fixture should work on the cant_read.html fixture with some allowed tags

are not related to this commit. I will send a fix for the other two.

gioele commented 11 years ago

Fixed by pull request #48.

cantino commented 11 years ago

Thanks!

On Sun, Mar 31, 2013 at 2:59 AM, Gioele notifications@github.com wrote:

Fixed by pull request #48https://github.com/cantino/ruby-readability/issues/48 .

— Reply to this email directly or view it on GitHubhttps://github.com/cantino/ruby-readability/pull/47#issuecomment-15689320 .