search

cantino / ruby-readability

Port of arc90's readability project to Ruby
Apache License 2.0
925 stars 171 forks source link

Fixes for #51 , #53 and #54 #55

Closed pagojo closed 10 years ago

pagojo commented 11 years ago

I hope this is good enough, it passes all rspec tests

cantino commented 11 years ago

Hi @pagojo, this looks good! Would you be able to add some test coverage for your changes?

pagojo commented 11 years ago

ok I will give it a go :-)

pagojo commented 11 years ago

sorry for the delay.... :-)

cantino commented 11 years ago

No worries, I appreciate your help!

cantino commented 10 years ago

Hey @pagojo, how are the specs going?

pagojo commented 10 years ago

Hi, I haven't had any time at all. i'll see if I can find some time this week otherwise it will be over the holidays. I have not forgotten about it though. Sorry :-/

cantino commented 10 years ago

No worries! Just checking in.

On Tuesday, December 10, 2013, pagojo wrote:

Hi, I haven't had any time at all. i'll see if I can find some time this week otherwise it will be over the holidays. I have not forgotten about it though. Sorry :-/

— Reply to this email directly or view it on GitHubhttps://github.com/cantino/ruby-readability/pull/55#issuecomment-30209038 .

pagojo commented 10 years ago

oops sorry again :-/

cantino commented 10 years ago

Haha. No worries. Should I work on some specs, or do you think you'll have time?

pagojo commented 10 years ago

Haha. No worries. Should I work on some specs, or do you think you'll have time?

if you could then it would make my hectic month much better :-)

Sorry again.

cantino commented 10 years ago

Well, I haven't had time either. :)

Do you think you'll get back to this?

pagojo commented 10 years ago

On 12 Jul 2014, at 22:39, Andrew Cantino wrote:

Well, I haven't had time either. :)

Do you think you'll get back to this?

oh, I thought you had pulled the patch in the previous releases no?

pagojo commented 10 years ago

So did you pull this patch after all? :-)

cantino commented 10 years ago

Hey @pagojo, no, it hasn't been merged. I think one or two basic specs would help. Do you have time to work on those?

pagojo commented 10 years ago

ok just did!! finally :-) Can yu please have a look and merge?

cantino commented 10 years ago

Merged! Thanks @pagojo!

pagojo commented 10 years ago

Thank you! When do you think we can have the new version of the gem ready for download? :-)

cantino commented 10 years ago

Just pushed it :)

cantino commented 10 years ago

Please test. I think I merged in your changes correctly, and the specs pass.

pagojo commented 10 years ago

This looks fine.

However I think I discovered another variant of a bug where images() doesn't return non-FQDN images that don't have their size set. I will report asap.