search

cantino / ruby-readability

Port of arc90's readability project to Ruby
Apache License 2.0
919 stars 170 forks source link

Add whitelist and blacklist support #70

Closed SamSaffron closed 10 years ago

SamSaffron commented 10 years ago

Adds 2 optional options for whitelisted and blacklisted selectors.

Whitelisted selectors are the only ones maintained in "body" Blacklisted selectors are stripped from body

I found we need this fidelity to work around issues for some problem sites like boing boing. Example included.

SamSaffron commented 10 years ago

1.9.2. is finicky with guard, do you want to keep support for it?

SamSaffron commented 10 years ago

also we should probably add 2.1.1

cantino commented 10 years ago

I'd be okay dropping 1.9.2 as long as we keep 1.9.3. And feel free to add 2.1.1.

SamSaffron commented 10 years ago

@cantino done.

SamSaffron commented 10 years ago

took care of latest comments. do you want me to squash or keep history?

SamSaffron commented 10 years ago

btw, for context we use readability at discourse, the patch it to enable us to get expansions here working http://bbs.boingboing.net/t/tick-tick-tick/28470, thanks heaps

cantino commented 10 years ago

Looks great, thanks for the contribution @SamSaffron! (Ah, Discourse, that's where I knew your name from. Were you at GoGaRuCo this year?)

SamSaffron commented 10 years ago

yes, I spoke there :) we had our team meetup at the same time.

cantino commented 10 years ago

Nice. I just pushed out 0.6.1 with these changes!

SamSaffron commented 10 years ago

thanks heaps