search

cantino / ruby-readability

Port of arc90's readability project to Ruby
Apache License 2.0
919 stars 170 forks source link

CI build failures #84

Closed olleolleolle closed 3 years ago

olleolleolle commented 3 years ago

One of the failures is about do_not_allow not being accessible in an RSpec ExampleGroup. Is that outside an "it"? Well, it fails.

Perhaps, as an update, the matrix of Ruby versions to run in CI could be updated, too!

andyw8 commented 3 years ago

I just started looking into this, and noticed there's no mention of load_image anywhere else in the code. It was renamed to get_image_size in 6fa12bbf1ab08168e22bf6a7ca104adb63fbef45.

olleolleolle commented 3 years ago

@andyw8 Thanks!

:hearts: :yellow_heart: :green_heart: :blue_heart: :purple_heart: