canton7 / PropertyChanged.SourceGenerator

Powerful INotifyPropertyChanged / INotifyPropertyChanging Source Generator, which generates INPC boilerplate for you as part of your build. Supports features such as automatic and manual dependencies between properties, notifications when specific properties change, and more.
MIT License
138 stars 14 forks source link

`PropertyChanged.SourceGenerator` stop generate code if the same class name exists in two namespace #4

Closed Cologler closed 2 years ago

Cologler commented 2 years ago

PropertyChanged.SourceGenerator raised ArgumentException if the same class name exists in two different namespaces.

To Reproduce

using PropertyChanged.SourceGenerator;

namespace ConsoleApp4
{
    partial class Class1
    {
        [Notify] string _a;
    }
}

namespace ConsoleApp5
{
    partial class Class1
    {
        [Notify] string _a;
    }
}
canton7 commented 2 years ago

Thanks for spotting these!

Shall I release this (and #2 and #3) now, or are you planning to open some more tomorrow?

Cologler commented 2 years ago

Thanks for your great work. If you can release the new version today, I can start to test it (on my project) beginning today.

Antony Male @.***> 于 2021年10月27日周三 03:10写道:

Thanks for spotting these!

Shall I release this (and #2 https://github.com/canton7/PropertyChanged.SourceGenerator/issues/2 and

3 https://github.com/canton7/PropertyChanged.SourceGenerator/issues/3)

now, or are you planning to open some more tomorrow?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/canton7/PropertyChanged.SourceGenerator/issues/4#issuecomment-952231336, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACTG2UQO2QCILFB5ZXS6KJDUI4DJZANCNFSM5GX73U6Q .

canton7 commented 2 years ago

Released as 1.0.1