canton7 / Stylet

A very lightweight but powerful ViewModel-First MVVM framework for WPF for .NET Framework and .NET Core, inspired by Caliburn.Micro.

MIT License

996 stars 144 forks source link

Missing OnClose/Dispose for inactive items of Conductor<T>.Collection.OneActive #18

Closed azabluda closed 7 years ago

azabluda commented 7 years ago

14 adds a regression. Methods `OnClose` and `Dispose` are only called for the active item when exiting the `Stylet.Samples.TabNavigation` application in 1.1.18. Both are expected to be called also for inactive items (as it was in 1.1.17).

canton7 commented 7 years ago

Turns out this was a different issue, which was unmasked in your test case after #14. Pre-1.1.17, you could trigger this by doing 'conductor.Items.Clear()`.

canton7 commented 7 years ago

Fixed in v1.1.19.

canton7 / Stylet

Missing OnClose/Dispose for inactive items of Conductor<T>.Collection.OneActive #18

14 adds a regression. Methods OnClose and Dispose are only called for the active item when exiting the Stylet.Samples.TabNavigation application in 1.1.18. Both are expected to be called also for inactive items (as it was in 1.1.17).

14 adds a regression. Methods `OnClose` and `Dispose` are only called for the active item when exiting the `Stylet.Samples.TabNavigation` application in 1.1.18. Both are expected to be called also for inactive items (as it was in 1.1.17).