search

canton7 / fuelphp-casset

Better asset management library for fuelphp (with minification!)
MIT License
103 stars 29 forks source link

add rename config property #51

Open TakaraShinya opened 10 years ago

TakaraShinya commented 10 years ago

I added giving file name property. Please merge my branch.

canton7 commented 10 years ago

A couple of things:

  1. Why? What does this add? The point of the naming on cache files is that the name changes whenever a file is modified, so the webserver can apply very eager caching rules. I could maybe see the point of prepending the group name for debugging purposes, but then why not turn off minifing/combining altogether?
  2. Please update the README and default config file.
  3. This should probably also be added to the per-group options, and therefore also to the quickref
TakaraShinya commented 10 years ago
  1. Beacause I didn't want to rename cache files. This cache files are make and renamed by webserver and cached on webserver. But my web application have many JS/CSS files are deployed to proxy server and get from proxy server by GET request. And then cached files on webserver not exist on proxy server.

2.　OK.　I'll do.

3.　OK.　I'll do.

canton7 commented 10 years ago

Aha, so they're part of some sort of asset pipeline? That makes sense. Casset was never intended to be used in that way :)

TakaraShinya commented 10 years ago
  1. I did. How is that?
  2. I don't know that I should write something to the quickref. Please teach me.