search

cantonbecker / bitcoinpaperwallet

JavaScript Client-Side Bitcoin Wallet Generator
https://www.bitaddress.org
452 stars 165 forks source link

unit test fails if "default setCryptoCurrency" != Bitcoin #12

Closed germanstudent closed 8 years ago

germanstudent commented 10 years ago

The unit test is implemented with bitcoin addresses only. If you intend to set up another default currency e.g. Litecoin:

default:
    setCryptoCurrency('Litecoin');

Source

the unit test will fail.

cantonbecker commented 10 years ago

Ooooh good point. Yes the unit tests will have to be re-written for each alt-coin since they contain pre-computed addresses/hashes and such. Thanks for pointing this out. I’ll have to figure out if I want to implement unit tests for each altcoin, or just disable the unit test link for alt coins.

On Mar 7, 2014, at 6:32 AM, germanstudent notifications@github.com wrote:

The unit test is implemented with bitcoin addresses only. If you intend to set up another default currency e.g. Litecoin:

default: setCryptoCurrency('Litecoin'); Source

the unit test will fail.

— Reply to this email directly or view it on GitHub.

Canton Becker canton@gmail.com • (505) 570-0635 • http://cantonbecker.com