Closed dcbr closed 9 months ago
Thanks for your contribution.
We're going to test that and merge.
Ok awesome :) Glad to see there is some activity for this extremely useful library!
I also noticed this project still uses tslint
, which has been deprecated for some years now. I tried to convert to eslint
, but I am not a linter expert and this caused some non-trivial changes (for me). So if someone is more familiar with that matter, I think it would be a good follow-up change.
Yes, we forked a project that was using a stack we're not so comfortable with. We'd like to slowly update it to a stack we know better.
Released in 1.20.3 Sorry for the mess in the repo. Was my first time trying to use the conflict resolution tool built in github and that didn't go well ^^" Thanks for your contribution. :heart:
No problem, thanks for the quick release! 🚀
What?
Fixes failing tests and lint checks.
Why?
As this project is the most active fork of Hopding/pdf-lib, I wondered if you would accept new contributions here? I'm mostly interested in extensions for PDF signing. To start developing from a fresh clone of this repository, the changes in this PR were necessary to correctly run all tests and lint checks.
How?
Mostly using
yarn upgrade
,yarn add
andyarn lint
commands, plus some manual fixes.Testing?
All tests run correctly now
New Dependencies?
No
Screenshots
N/A
Suggested Reading?
No
Anything Else?
N/A
Checklist