search

canva-public / flourishcharts

Interactive data visualization Python and R packages for data scientists.
20 stars 1 forks source link

Getting "isFixedHeight is not defined" error after fresh install of the R package #7

Open maartenzam opened 1 week ago

maartenzam commented 1 week ago

After installing the R package, I get the following error in the RStudio Viewer pane after running the examples from the Creating Flourish graphs in R and Python page:

ERR: Uncaught ReferenceError: isFixedHeight is not defined
URL:http://localhost:14338/session/viewhtml169e2fa3914/lib/flourish-live-binding-1.0.0.3/flourish-live.jsL:89
zmeers commented 1 week ago

Hey @maartenzam - I've just installed the R package version from GitHub (not CRAN) which is the R package v.1.0.0.1 and it works, so try that.

Installing directly from CRAN shows the same error:

Screenshot 2024-11-21 170146

Installing from GitHub works:

Screenshot 2024-11-21 170529

Apologies, I've just moved on from Canva so am unable to fix the issue myself.

FYI @maxious @luptilu -- it looks like there was a regression from v1.0.0.1 to v1.0.0.3. v1.0.0.3 was submitted to CRAN and is currently only available in the private repo. The most recent PRs there should let you know what changed.

You can either: (a) just submit v1.0.0.1 to CRAN by downloading this repo, building the tar ball and submitting that to CRAN - it will overwrite v.1.0.0.3. The person doing this will need to become the R package maintainer to submit to CRAN - not a big deal, just update DESCRIPTION file.

(b) Fix the underlying issue - I'm not sure what that is - and push to NPM. Once this is done the R package should update in the GH private repo on Monday, but the push to CRAN will need to be done manually.

Can walk someone through this process if need be.