canva-public / js2nix

Node.js modules installation using Nix
MIT License
63 stars 14 forks source link

Use integrity Field from yarn.lock as sha512 for Nix Derivation #11

Open pathway27 opened 1 year ago

pathway27 commented 1 year ago

The newset yarn version (1.22.19) generates yarn.lock files which don't have the sha1 in their url with a #, so fails for some users. One public example I've found: https://github.com/iptv-org/iptv/blob/master/yarn.lock#L7.

But I notice most lockfiles have an integrity field. See https://github.com/canva-public/js2nix/blob/main/yarn.lock#L8

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

olebedev commented 1 year ago

Hey @pathway27, thanks for raising this issue, this is true, we can leverage this field from the modern-built lockfiles.

The build seems failing, would you mind to fix it before the review? Thanks!