search

canvas-medical / fhirstarter

An ASGI FHIR API framework built on top of FastAPI and FHIR Resources
MIT License
30 stars 15 forks source link

Retire support for FHIR R4 #296

Closed csande closed 1 month ago

csande commented 1 month ago

Is your feature request related to a problem? Please describe.

FHIR R4 is a subset of FHIR R4B, so there is no need to support both sequences separately in the code. Anyone that wants FHIR R4 can just use FHIR R4B.

Describe the solution you'd like

The implementation should be straightforward -- simply removing recognition for FHIR R4 by the code that reads the environment variable will suffice. Doing this will allow for some refactors and simplifications:

Describe alternatives you've considered

I considered continuing support for FHIR R4 by simply aliasing it to FHIR R4B, but considering that fhir.resources requires you to specify "R4B" in the import path, it is better to just make a hard break for clarity.

csande commented 1 month ago

I am closing this due to incorrect information.

I filed this based on information on this page: https://hapifhir.io/hapi-fhir/docs/getting_started/r4b.html

It may be true that functionally, FHIR R4B is a superset of FHIR R4, but it is not true contractually. See here:

https://hl7.org/fhir/R4B/r4b-explanation.html