caofangkun / closure-templates

Automatically exported from code.google.com/p/closure-templates
Apache License 2.0
0 stars 0 forks source link

CodeReview: Add Go Support for Closure Templates #35

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
I've uploaded a code review that adds Go Support for Closure Templates

http://codereview.appspot.com/4245045/

Tested on Mac OS X 10.6.6 with the latest version of Go from 2011-02-17.

Please let me know if there is anything I need to do to get this patch into the 
svn repository

Original issue reported on code.google.com by pom...@gmail.com on 27 Feb 2011 at 5:59

GoogleCodeExporter commented 8 years ago
Nice. Sign a contributor license so that your patch can be considered:

http://code.google.com/legal/individual-cla-v1.0.html

After that, send a message to the mailing list if you didn't already.

Original comment by rodrigo.moraes on 12 Jul 2011 at 11:19

GoogleCodeExporter commented 8 years ago
Also, it'd be a good idea to provide a patch with only the added/modified 
files, not including files that were updated by building tools like javadoc, 
e.g.:,

http://codereview.appspot.com/4245045/patch/1/99

Original comment by rodrigo.moraes on 12 Jul 2011 at 11:28

GoogleCodeExporter commented 8 years ago
FYI, we're not ready to take contributions in this project yet. We're slowly 
working toward that, but have limited people/time to do it.

Also FYI, at some point, when we get around to making the next release, we'll 
be releasing months of code changes, so the code base will be quite different. 
You'll have to make some modifications at that point to make your code work 
against the new code base. We're sorry about the inconvenience.

Original comment by k...@google.com on 12 Jul 2011 at 5:30

GoogleCodeExporter commented 8 years ago
Thanks for posting this note.

I was just starting to look at it to make a compiler for Python. I should 
probably wait for the next release then...

Original comment by rodrigo.moraes on 12 Jul 2011 at 7:21

GoogleCodeExporter commented 8 years ago
That release is now out.

Original comment by mikesamuel@gmail.com on 20 Sep 2011 at 8:18

GoogleCodeExporter commented 8 years ago

Original comment by brendan....@gmail.com on 26 Feb 2015 at 11:57