caojiezhang / VSR-Transformer

PyTorch implementation of VSR-Transformer
252 stars 28 forks source link

Bug report #7

Closed ChenShuwei1001 closed 3 years ago

ChenShuwei1001 commented 3 years ago

A bug hard to notice: in 'basicsr/models/crop_validation.py', the beginning of method 'forward_crop', two assert statements are used: assert lq_size == 64 or 48, "Default patch size of LR images during training and validation should be {}.".format(lq_size) assert overlap == 16 or 12, "Default overlap of patches during validation should be {}.".format(overlap) you should insteadly use assert lq_size == 64 or lq_size ==48, "Default patch size of LR images during training and validation should be {}.".format(lq_size) assert overlap == 16 or lq_size ==12, "Default overlap of patches during validation should be {}.".format(overlap) because origin statement will be explained as assert (lq_size==64) or (48), which is always True