search

caolan / async

Async utilities for node and the browser
http://caolan.github.io/async/
MIT License
28.18k stars 2.41k forks source link

Update queue.js #1871

Closed heartforit closed 2 years ago

heartforit commented 2 years ago

This fixes an bug: Drain function got called even when some tasks still ongoing at the queue. Fix proposal is due to https://github.com/caolan/async/issues/1729 (@Domiii) Tested by me locally. Works great.

aearly commented 2 years ago

You will need to fix the tests.

heartforit commented 2 years ago

I won't. I cancel my pull request. Tought will be esay and fast but it will not.

heartforit commented 2 years ago

I will not fix this. I will switch to another option.

Domiii commented 2 years ago

@aearly @heartforit Fixed my snippet. See original issue: #1729