search

caolan / jam

JavaScript package manager - using a browser-focused and RequireJS compatible repository
MIT License
1.5k stars 105 forks source link

Feature: Pull Requests #128

Open jonsharratt opened 11 years ago

jonsharratt commented 11 years ago

Hi @caolan,

If you get a moment I have started putting together a feature that you may or may not agree with. It has become apparent there is a bit of a blocking issue when other contributors wish for a repository to be updated.

I have a commit that starts and fundamentally works in which anyone will be able to submit a pull request for a package, using commands as follows:

jam pullrequest PACKAGE_FOLDER jam pullrequest PACKAGENAME@VERSION --accept

Current code can be found at: https://github.com/redbadger/jam/commit/31acaa06e320baae7fc351d71d8edc0ea12ba722

I have this working with integration tests but need some help in getting my local testing couchdb environment setup so that the permissions react in the same way. This means for owners I can ensure the code will work when a non owner tries to publish a pull request against a package they do not own and also when a non owner of the package for a pull request accept may happen.

Any thoughts or feedback on whether you or anyone else thinks this feature would be helpful would be appreciated.

Look forward to hearing from you.

caolan commented 11 years ago

Interesting idea, how would you alert the package owner that there is a pull request pending? Currently the website doesn't send any emails but it might be a good idea in the future.