caomw / google-glog

Automatically exported from code.google.com/p/google-glog
Other
0 stars 0 forks source link

signalhandler_unittest meant not be to be run on PowerPC systems are ran and failed #200

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Take the release  glog-0.3.3.tar.gz
2. Building this package in a new platform ppc64le and hence did autoreconf -f 
-i to have the updated autotools which has the support for ppc64le.
3. make followed by make check

What is the expected output? What do you see instead?

The test case is failing with this error.

./src/signalhandler_unittest.sh
grep: signalhandler.out2: No such file or directory
'SIGFPE' should appear in the output
make[1]: *** [signalhandler_unittest_sh] Error 1

The expected output the piece of code which is causing the failures should not 
have entered as the testcase is designed to skip for PowerPC systems and the 
test is ran on such a system.

What version of the product are you using? On what operating system?

The  glog-0.3.3.tar.gz and also verified in the latest source.
Operating system: Ubuntu 14.04
Architecture : ppc64le

Please provide any additional information below.

On analysing the ./src/signalhandler_unittest.sh

found this piece of code
# The PC cannot be obtained in signal handlers on PowerPC correctly.
# We just skip the test for PowerPC.
if [ x`uname -p` = x"powerpc" ]; then
  echo "PASS (We don't test the signal handler on PowerPC.)"
  exit 0
fi

This test case is ran in a PowerPC system. But the uname of these architectures 
does not go by the name "powerpc".
Those names are like ( ppc64, ppc64le , ppc , ppcle)

The test case is designed to skip for powerpc processor system.
But because of the incorrect with string "powerpc" which is not matching the 
actual string "ppc64le" in this case, the test case is continued and failing 
ultimately.

Original issue reported on code.google.com by mailtora...@gmail.com on 29 Apr 2014 at 12:00