cap-collectif / ui

Design system of @cap-collectif with react • styled-components • styled-system
https://ds.cap-collectif.com/
MIT License
16 stars 0 forks source link

fix: remove circular dependency on modal component #464

Closed myracodes closed 4 weeks ago

myracodes commented 4 weeks ago

:tophat: What? Why?

On a un warning sur des dépendances circulaires dans le composant Modal. Cette PR corrige le souci. Pas besoin de faire une release, ça sera embarqué dans la prochaine

:pushpin: Related Issues

Pas d'issue créée, juste ce warning au moment du yarn

⠧ Building modules
Circular dependency: src/components/modal/header/ModalHeader.tsx -> src/components/modal/headerLabel/ModalHeaderLabel.tsx -> src/components/modal/header/ModalHeader.tsx
Circular dependency: src/components/modal/header/ModalHeader.tsx -> src/components/modal/headerLabel/ModalHeaderLabel.tsx -> src/components/modal/header/ModalHeader.tsx
Circular dependency: src/components/modal/header/ModalHeader.tsx -> src/components/modal/hea
✓ Building modules 2.9 mins
✨  Done in 175.52s.

:clipboard: Technical Specification

:art: Chromatic links

:camera_flash: Screenshots