OData services stopped working after deployment of plugin

cap-js / attachments

The @cap-js/attachments package is a CDS plugin that provides out-of-the box asset storage and handling by using an aspect Attachments. It also provides a CAP-level, easy to use integration of the SAP Object Store.

Apache License 2.0

12 stars 4 forks source link

OData services stopped working after deployment of plugin #50

Closed naveenvishal closed 3 months ago

naveenvishal commented 4 months ago

Hi Team,

I have used the plugin in my model.cds but the project goes into hang state and shows no error in terminal as shown in image.

Even as an extend model, its shows the same result as hanged.

Please suggest.

muskansethi1 commented 4 months ago

Hi @naveenvishal,

What is the version of ui5 been used? You can check this here in the index.html in the webapp : src="https://ui5.sap.com/**1.121.0**/resources/sap-ui-core.js"

naveenvishal commented 4 months ago

Hi @muskansethi1 ,

The ui5 version in the index.html in the webapp says src="https://sapui5.hana.ondemand.com/1.123.1/resources/sap-ui-core.js"

muskansethi1 commented 4 months ago

Hi @naveenvishal ,

Can you try changing to version 1.121.0 once and see if it works then?

naveenvishal commented 4 months ago

Hi @muskansethi1 ,

Version change work fine, thank you ! But another issue now pops-up.

I am facing below error when I deployed app to HANA db and ran 'cds watch --profile hybrid'

EDIT: I ignored the above run error and deployed to production, but it fails saying unable to start the service.

EDIT: OPERATION (1).log The file have 3 trials with error during deploy.

naveenvishal commented 4 months ago

Problem persist and issues are there in deploy. I tried to include in package.json as "attachments": { "kind": "db" }
but the issues are there deployed as shared in file above. Additionally, if I include it as 'requires', it stops the SF odata execution.

EDIT: I am able to deploy it to production and it is working fine, but the only issue remains is it stops other Odata services to SF.

naveenvishal commented 4 months ago

Hi @muskansethi1 ,

Please suggest do I need to modify xs-app.json or mta.yaml file with any changes for this plugin.

I have updated package.json with following changes to include the plugin and changes works fine in development. "attachments": { "kind": "db" } But in production, plugin works fine but it is causing conflict with pre-existing OData service.

https://community.sap.com/t5/technology-q-a/odata-services-stopped-working-after-deployment-of-plugin/qaq-p/13705337

Please suggest if I need to additionally include the plugin details somewhere (mta.yaml, xs-app.json, manifest.json).

muskansethi1 commented 4 months ago

Hi @naveenvishal,

I will have a look into this issue and get back to you.

naveenvishal commented 4 months ago

Hi @muskansethi1 ,

Please check the issue https://github.com/cap-js/attachments/issues/52 for a well detailed steps of analysis and execution for the replication of the issue. Thanks to MioYasutake for detailed analysis.

naveenvishal commented 4 months ago

Hi @muskansethi1 ,

Just to update that with attachments new build release, the issue is still not fixed for me.

MioYasutake please check from your end.

muskansethi1 commented 4 months ago

Hi @naveenvishal, We are still looking into this issue, the fix hasn't been released yet

naveenvishal commented 4 months ago

Hi @muskansethi1 , With 'Fixes for deployment' I thought it is related to this issue, my bad.

muskansethi1 commented 3 months ago

Hi @naveenvishal

We have identified the issue and are currently discussing it with the concerned colleagues about the same.

Best Regards, Muskan

muskansethi1 commented 3 months ago

Hi @naveenvishal ,

We have found the fix for this issue and will release it in the next version soon.

Best Regards, Muskan

muskansethi1 commented 3 months ago

Hi @naveenvishal , The fix is released in @cap-js/attachments@1.1.2. Please let me know if there are any issues.

Best Regards, Muskan