cap-js / audit-logging

CDS plugin providing integration to the SAP Audit Log service as well as out-of-the-box personal data-related audit logging based on annotations.
https://cap.cloud.sap/docs/guides/data-privacy
Apache License 2.0
4 stars 1 forks source link

Audit log service registration fails if any service exists without relevant entities #66

Closed ck518 closed 7 months ago

ck518 commented 7 months ago

Hi!

If there's a service in your application without any entity relevant for audit logging, the service registration stops.

Please check the following code line, I think it should be "continue" instead of "return":

https://github.com/cap-js/audit-logging/blob/a1bc49648149f465a9fbed047b305e60b91b9570/cds-plugin.js#L20

Dependent on the registration sequence some services might not be handled at all.

Thanks and best regards, Christian

ck518 commented 7 months ago

@johannes-vogel Thanks for the quick fix! Can you already estimate when the corresponding next release will be available for consumption?

sjvans commented 7 months ago

0.5.1 was released